I'd take a look at what Crowley/Golden Dawn has to say on the topic (Nicely encapsulated here:
https://www.biddytarot.com/tarot-astrology-golden-dawn/). These likely also apply to Waite's deck. Keep in mind that many tarot card creators have their own take on which astological sign/planet/element goes with which card. This is especially true when you get to the Courts. Pick up different decks, even RWS clones, and you'll see the creator's own take on what zodiac sign should be attributed to which court. The Queen/Cups, for example, might have a crab at her feet for Cancer, or have a pisces sign etched on her throne. Which should she be? You'll hear all kinds of arguments that validate either choice
In fact, if you will permit a digression here...allow me to elaborate on this point. As court card zodiac signs are the most frequently discussed zodiac-tarot-cards topic you'll see here
The problem that is that readers assume that court-card-signifiers have to reflect the sitter's rising sign. This isn't true at all! A sitter might be Virgo, and yet not seem like a Knight/Pents. They may seem like a Queen/Swords. If so, that should be their signifier. As you know, we are more than just our rising signs, and signifiers should reflect who the person is at this time in their life (or the situation relating to the reading). Or even the card the sitter, themselves, identify with. If that is their rising-sign court card, fine. But if not, that's fine, too.
Where the zodiac signs of courts really matter is when the reader needs extra help. So, you get the Knight/Pents in a reading and think he stands for someone the sitter knows. Who? Well, after running down possibilities, you might ask "Do you know a Virgo?" And the sitter might say, "Ah, yes, that's probably who it is..."
Ultimately, it will become your decision whether to follow what the Golden Dawn (and their ilk like Waite and Crowley) decided in regards to court-card-zodiac or your own strong feelings. All that I would recommend--as a good idea for any tarot reader--is that you remain consistent. Meaning (1) You keep to Earth signs for the Pentacles, water signs for the cups, etc. and (2) that if you give a fixed sign to one queen then give fixed signs to all. This is practical (helps you remember who gets which) and makes sense.
By makes sense I mean that you'll hear about readers who identify with a certain court card, and feel it should have their rising sign even if it doesn't make sense. For example, there was one thread arguing that the Queen/Swords ought to be Virgo. Whether she has Virgo elements or not wasn't the point. The "makes no sense" part was that the reader would end up with an unassigned air sign, and unassigned Pentacle card. What is the Knight/Pentacles if you give Virgo to the Queen? And who gets Aquarius? The Knight/Pents? That doesn't make any sense
Anyway, that's my little digression on the topic. Hope it helps.